Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Change filter definition's page limit from float to int #195

Open
dolmit-tanel-paaro opened this issue Sep 4, 2024 · 1 comment

Comments

@dolmit-tanel-paaro
Copy link
Contributor

dolmit-tanel-paaro commented Sep 4, 2024

Improvement description

I'm proposing this change because I recently run into an issue where I programmatically set filter definition's page limit:
$filterDefinition->setPageLimit(PHP_INT_MAX)

As page limit is float, PHP_INT_MAX gets converted to float: 9.2233720368548E+18
This resulted in SQL syntax error.

I don't see any practical reason for page limit to be float - you won't be loading half or 1.2 items at a time.

Ref:

abstract public function getPageLimit(): ?float;

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant