You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm proposing this change because I recently run into an issue where I programmatically set filter definition's page limit: $filterDefinition->setPageLimit(PHP_INT_MAX)
As page limit is float, PHP_INT_MAX gets converted to float: 9.2233720368548E+18
This resulted in SQL syntax error.
I don't see any practical reason for page limit to be float - you won't be loading half or 1.2 items at a time.
Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.
Improvement description
I'm proposing this change because I recently run into an issue where I programmatically set filter definition's page limit:
$filterDefinition->setPageLimit(PHP_INT_MAX)
As page limit is
float
,PHP_INT_MAX
gets converted to float:9.2233720368548E+18
This resulted in SQL syntax error.
I don't see any practical reason for page limit to be float - you won't be loading half or
1.2
items at a time.Ref:
ecommerce-framework-bundle/src/Model/AbstractFilterDefinition.php
Line 33 in 5e105cf
The text was updated successfully, but these errors were encountered: