Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Creating offer from cart throws error #162

Open
GAL-CS opened this issue Feb 26, 2024 · 1 comment
Open

[Bug]: Creating offer from cart throws error #162

GAL-CS opened this issue Feb 26, 2024 · 1 comment

Comments

@GAL-CS
Copy link

GAL-CS commented Feb 26, 2024

Expected behavior

No error is thrown.

Actual behavior

An error is thrown:

Pimcore\Model\DataObject\OfferToolOffer::setCartId(): Argument #1 ($cartId) must be of type ?string, int given, called in /var/www/html/vendor/pimcore/ecommerce-framework-bundle/src/OfferTool/DefaultService.php on line 84

Steps to reproduce

Call createNewOfferFromCart in https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/OfferTool/DefaultService.php#L78.

When this function wants to store the cart ID on the offer, an error is thrown because $cart->getId() can also return an integer, but $offer->setCartId() only accepts null or a string. (https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/OfferTool/DefaultService.php#L84)

@GAL-CS GAL-CS added the Bug label Feb 26, 2024
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant