You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pimcore\Model\DataObject\OfferToolOffer::setCartId(): Argument #1 ($cartId) must be of type ?string, int given, called in /var/www/html/vendor/pimcore/ecommerce-framework-bundle/src/OfferTool/DefaultService.php on line 84
Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.
Expected behavior
No error is thrown.
Actual behavior
An error is thrown:
Pimcore\Model\DataObject\OfferToolOffer::setCartId(): Argument #1 ($cartId) must be of type ?string, int given, called in /var/www/html/vendor/pimcore/ecommerce-framework-bundle/src/OfferTool/DefaultService.php on line 84
Steps to reproduce
Call
createNewOfferFromCart
in https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/OfferTool/DefaultService.php#L78.When this function wants to store the cart ID on the offer, an error is thrown because
$cart->getId()
can also return an integer, but$offer->setCartId()
only accepts null or a string. (https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/OfferTool/DefaultService.php#L84)The text was updated successfully, but these errors were encountered: