Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Price filter "not implemented yet" #141

Open
Fabian-Hofer-Mastertent opened this issue Nov 27, 2023 · 1 comment
Open

[Bug]: Price filter "not implemented yet" #141

Fabian-Hofer-Mastertent opened this issue Nov 27, 2023 · 1 comment

Comments

@Fabian-Hofer-Mastertent

Expected behavior

I made a custom price filter and added a price condition to the product list.
Expected would be that the ecommerce-framework handles the filter and sorting when the price filter is set.

Actual behavior

Adding the price condition results in an "Not implemented yet"-Exception because two of the four functions in the Pimcore\Bundle\EcommerceFrameworkBundle\IndexService\ProductList\DefaultMySql are not implemented yet.
There are four functions in the class that handle the four cases:

  • no price filter, no price sorting
  • no price filter, with price sorting
  • with price filter, no price sorting
  • with price filter, with price sorting

the last two functions are not implemented.

I think i could extend the DefaultMySql class somehow and write the functions myself, but I have a bit difficulty to override them correctly because the ecommerce-config does not give me any options to do that. (like with the MySqlConfig or Worker classes)

Steps to reproduce

  1. Create your own FilterTye (i named mine "PriceFilter") that extends the AbstractFilterType
  2. in the addCondition function call the "$priceFilter->addPriceCondition" function with from and to price
  3. add the new FilterType to your filter
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant