Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Unify Setting Key and Path #444

Open
cancan101 opened this issue Dec 19, 2024 · 1 comment
Open

[Feature]: Unify Setting Key and Path #444

cancan101 opened this issue Dec 19, 2024 · 1 comment

Comments

@cancan101
Copy link
Contributor

Feature description

Currently the Path is specified on the "Resolver":
Image

but the Key is specified as a Mapping:
Image

I suggest adding the ability to set the Path using the mapping as well. This would (a) allow for consistency of config and more importantly (b) allow using the transforms to compose the path. Currently we ave to maintain logic outside of the importer since the path needs to be a specific field in the file.

@fashxp
Copy link
Member

fashxp commented Jan 2, 2025

I like the idea, but isn't the mapping (as it is right now) too late for the path as the path is needed during resolving?

Probably we would need a resolver strategy that also provides (at least a subset) of the mapping functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants