-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torq IT New Additions #382
Conversation
…qIT/data-importer into feature/torqit-new-additions
…qIT/data-importer into feature/torqit-new-additions
…qIT/data-importer into feature/torqit-new-additions
…qIT/data-importer into feature/torqit-new-additions
…to feature/torqit-new-additions
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
recheck |
Can you please merge or rebase the changes from 1.x to your PR? This is mostly for using qodana to check the PR. |
Done |
@herbertroth can you point me in the correct direction to sign the CLA? I am not getting a prompt here like the main Pimcore repo. |
You can sign the CLA by just posting a Pull Request Comment same as the below format. I have read the CLA Document and I hereby sign the CLA |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@jeremygnoonan Sorry, there was a problem with the allowlist in our cla check. github-actions[bot] was not in this list. So please rebase again... |
I have read the CLA Document and I hereby sign the CLA |
@herbertroth done |
@jeremygnoonan Sorry, sorry, sorry... pleas rebase again... |
Hi Jeremy, First and foremost, thank you so much for your extensive contribution to our project! After reviewing your pull request, it appears that it contains some breaking changes, such as the addition of a method to an interface and typed properties to existing ones. Before you embark on the task of splitting the PR, we suggest reaching out to our enterprise support team. Once again, thank you for your dedication to improving our project. Best regards, |
As discussed with @fashxp regarding a number of new features to the data importer. Had started a private extensions repo @ Torq but then decided to connect with Pimcore and see if any of it was interest to pull into the main repo.
Did my best to update the docs, so a good place to reference everything that has changed.
Highlights:
Submitting this as draft as I want to do some additional testing, but also wanted to give visibility.