Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When setting 'System Key' with empty value, import just dies #367

Closed
fashxp opened this issue Sep 27, 2023 · 1 comment · Fixed by #373
Closed

[Bug] When setting 'System Key' with empty value, import just dies #367

fashxp opened this issue Sep 27, 2023 · 1 comment · Fixed by #373
Assignees
Labels
Milestone

Comments

@fashxp
Copy link
Member

fashxp commented Sep 27, 2023

Expected behavior

get a error message into application logger, and not just having importer stuck

Actual behavior

13:23:37 WARNING   [messenger] Error thrown while handling message Pimcore\Bundle\DataImporterBundle\Messenger\DataImporterMessage. Sending for retry #3 using 4000 ms delay. Error: "Handling "Pimcore\Bundle\DataImporterBundle\Messenger\DataImporterMessage" failed: Pimcore\Model\DataObject\AbstractObject::setKey(): Argument #1 ($key) must be of type string, null given, called in /var/www/html/vendor/pimcore/data-importer/src/Mapping/DataTarget/Direct.php on line 119" ["class" => "Pimcore\Bundle\DataImporterBundle\Messenger\DataImporterMessage","retryCount" => 3,"delay" => 4000,"error" => "Handling "Pimcore\Bundle\DataImporterBundle\Messenger\DataImporterMessage" failed: Pimcore\Model\DataObject\AbstractObject::setKey(): Argument #1 ($key) must be of type string, null given, called in /var/www/html/vendor/pimcore/data-importer/src/Mapping/DataTarget/Direct.php on line 119","exception" => Symfony\Component\Messenger\Exception\HandlerFailedException^ { …}]

Steps to reproduce

  • create import with a mapping that assigns a value to the System Key
  • try to import an empty value to this
@fashxp fashxp added the Bug label Sep 27, 2023
@dvesh3 dvesh3 added this to the 1.8.4 milestone Sep 27, 2023
@aryaantony92 aryaantony92 self-assigned this Sep 28, 2023
@dvesh3 dvesh3 modified the milestones: 1.8.4, 1.8.5 Sep 28, 2023
@aryaantony92
Copy link
Contributor

Not able to reproduce the exact error. I tried with an empty key and got the exception

Exception: DataObject requires key in /var/www/html/dev/pimcore/pimcore/models/DataObject/AbstractObject.php:688

image

Also, the importer didn't get stuck because of the exception. The next element was imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants