[Improvement]: inconvenient namespace for datahub:graphql:rebuild-definitions command

[jeykodev]

Improvement description

After changing my PIMCORE_WRITE_TARGET_DATA_HUB from symfony-config to settings-store (see Docs) I looked for a possibility to rebuild the definitions, so the configuration will be initial saved in the database instead of config files.

I've found the metioned command but it has the namespace graphql and since I'm using the Data Importer, I thought this will be not an option.

After that, I looked into the command and found out, that no additional checks for the specific configuration type graphql are implemented. At the end the command does rebuild every configuration type, not only graphql.

So I would suggest to remove the graphql namespace from the command and adapt the description and documentation.

If you guys agree, I can make a PR.

[kingjia90]

@jeykodev Thank you for reporting, we would glad to see a PR about the change.
I have also got a tip that this change may need a BC Layer/Alias to avoid any BC Break, hope this would help you as well when making the PR.

[mcop1]

Deprecation is already there

data-hub/src/Command/GraphQL/RebuildDefinitionsCommand.php

Line 47 in 7652b48

*@deprecated Use Pimcore\Bundle\DataHubBundle\Command\Configuration\RebuildWorkspacesCommand instead.

+

data-hub/doc/20_Deployment.md

Line 26 in 44a4c3b

>Note: The command ```datahub:graphql:rebuild-definitions ``` is marked as deprecated and will be removed in a future release.

, the command just needs to be removed with the next major version.

Therefore no need to change the old command, just use the new one.

[fashxp]

see also #480