Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend Email not working with dynamic recipient field #781

Open
la-lisa opened this issue Dec 4, 2024 · 1 comment
Open

Resend Email not working with dynamic recipient field #781

la-lisa opened this issue Dec 4, 2024 · 1 comment

Comments

@la-lisa
Copy link
Contributor

la-lisa commented Dec 4, 2024

Image

I use dynamic fields of a form, to set the emails recipient based on the input. I set my "to" fields with the variable seen in the screenshot. When initially sending the email all works fine. When i try to resend it in the email Logs, it fails due to email RFC validation.
I found out that the resend email action in Email Controller sets the Document again, where all fields of the documents are set to (also the recipients in the setDocumentSettings function of lib/Mail).

if ($emailLog->getDocumentId()) {
    $mail->setDocument($emailLog->getDocumentId());
 }

In this function call the "to-address" gets already verified and fails due to my dynamic variable not being a valid email address. Before setting the document all relevant fields are already set from the EmailLog Object. All Params are also passed of the EmailLog Object.
So why not remove the setDocument call? When resending the Email i want to resend the exact same Mail which was initially sent, the document should not be needed.
Setting dynamic fields in Mails should be possible.

Image

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant