Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a solution to re-enable mangling option for grunt build. #98

Open
pilwon opened this issue Feb 21, 2014 · 1 comment
Open

Find a solution to re-enable mangling option for grunt build. #98

pilwon opened this issue Feb 21, 2014 · 1 comment

Comments

@pilwon
Copy link
Owner

pilwon commented Feb 21, 2014

No description provided.

@yaru22
Copy link
Collaborator

yaru22 commented Mar 15, 2014

ngmin is not working seamlessly with our project setup.

For example, if I run ngmin on one of our controllers (e.g. auth/controllers/login.js), this is what we get:

exports = module.exports = function (ngModule) {
  ngModule.controller('LoginCtrl', function ($scope, alert, auth, layout) {
    ...
  });
}

The dependencies are not annotated correctly because ngmin doesn't know that ngModule is angular.module(...) since it's coming from external source.

I think this work (btford/ngmin/pull/61) can be used for our purpose as well once it's pulled.

Also, see http://craigbeck.github.io/blog/2013/12/11/ui-dot-router-gotcha/ and btford/ngmin#54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants