Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor+React #16

Open
trusktr opened this issue Jul 24, 2015 · 6 comments
Open

Meteor+React #16

trusktr opened this issue Jul 24, 2015 · 6 comments
Labels

Comments

@trusktr
Copy link

trusktr commented Jul 24, 2015

Hello @pilwon! I want to finish rocket:module then use it to import this into Famous.

I tried to make a basic wrapper for Famous Node in my Meteor project to see how it might be, and I love the imperative nature of React; it'll be awesome to use React with Famous. It seems that to make the Node work, I have to return a React.Component from the render function of my component Node that also extends React.Component, so it creates a virtual DOM and a real DOM. Did you ever find a way around this? Maybe there's a way to make React have a virtual DOM for our Famous components but not output that to real DOM so it doesn't slow things down?

Famous Engine is getting a lot better. In 0.7 (coming out soon) they have the new Element Cache life cycle with an official way to get a DOMElement's DOM element!

@trusktr
Copy link
Author

trusktr commented Jul 26, 2015

@pilwon I've finished the first usable version of rocket:module yesterday. I'll be using it this week to import react-famous into Meteor and I'll post an example of that for the Meteor community to benefit from. :D I'd like to help update react-famous to Famous Engine 0.6+.

@trusktr
Copy link
Author

trusktr commented Jul 26, 2015

I'd like to make a package for Meteor: rocket:react-famous (unless you want to, if you use Meteor). It'll showcase the use of rocket:module, which will showcase the use of react-famous. 😊😀

@pilwon
Copy link
Owner

pilwon commented Jul 29, 2015

@trusktr Great to hear you made some great progress on rocket:module 👍 Unfortunately I'm not a Meteor dev so please enlighten me and the community how this Meteor+React will look like. Let me know what help you need from me for making this happen.

@pilwon pilwon added the discuss label Jul 29, 2015
@trusktr
Copy link
Author

trusktr commented Jul 29, 2015

For sure! The rocket:module package in Meteor is using npm to get deps and Webpack to compile stuff.

Basically, we just need to work on #17 to clean up package.json and it'll work really well.

@trusktr
Copy link
Author

trusktr commented Aug 3, 2015

Hi @pilwon ! ALright, so I've got react-famous working nicely in Meteor now. I'm going to start developing and will make some PRs soon. For now, check out my branch of react-famous. You'll notice that it's as minimal as possible. Check out the build scripts in package.json. There are still a few things to do though. One thing is to make the build script share Babel functions in a single file instead of duplicating them in each built file in the npm run prepublish script.

I'm testing all of this in the reacfamo package, for now, until we can get react-famous updated. It's working great.

I'm gonna post an example of it in Meteor in my example app, although it'd also be nice to update your react-famous-seed project with the bare minimal things: webpack, react, react-famous, and famous.

Looking forward to getting this all running. Cheers mate! 😃

@trusktr
Copy link
Author

trusktr commented Aug 3, 2015

I made a PR to track the work. I'll be working with @adamelk on our Meteor projects using/testing/improving the setup. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants