Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nim v2.0 compatibility #161

Closed
pietroppeter opened this issue Dec 22, 2022 · 1 comment · Fixed by #169
Closed

nim v2.0 compatibility #161

pietroppeter opened this issue Dec 22, 2022 · 1 comment · Fixed by #169
Assignees
@HugoGranstrom
Labels
2023H1
Milestone
2023H1

Comments

@pietroppeter
Copy link
Owner

have not tested yet how it works, but we should (and we should also add devel to CI).

as far as I know we do have an outstanding issue there, indeed when testing adding nimib to important packages, an issue was found related to toml dependency. The workaround currently is to revert using old gc (i.e. add -mm:refc).

Ideally we could:

  • help fix the toml dependency (better option, I do not have ideas on how to proceed there currently)
  • find a workaround in nimib (worse option and possibly not even something that could be done...)
@pietroppeter
Copy link
Owner Author

situation might be unblocked, the blocker was fixed, we can track nim-lang/Nim#20697 to see if it is solved.

to close this we should anyway add nim devel to CI

@pietroppeter pietroppeter mentioned this issue Feb 1, 2023
Merged
@pietroppeter pietroppeter added this to the 2023H1 milestone Feb 1, 2023
pietroppeter added a commit that referenced this issue Feb 9, 2023
@pietroppeter @HugoGranstrom
Adding devel to CI, fix #161, fix #149 (#169)
e25ee44 
* Adding devel to CI

I am adding both stable (that will become 2.x soon) and devel (which is candidate for 2.x). Also update versions of cache and setup-nim-action

* disable fail-fast for test CI

see https://stackoverflow.com/a/65647509/4178189

* Change toml lib + fix macro bug on devel (#173) (#174)

* fix orc macro bug

* replace toml_serialization with parsetoml

* clean up

* use jsony for deserialization as it can handle missing fields

Co-authored-by: Hugo Granström <[email protected]>

* bump to 0.3.6

---------

Co-authored-by: Hugo Granström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HugoGranstrom HugoGranstrom

Labels
2023H1
Projects
None yet
Milestone
2023H1
Development

Successfully merging a pull request may close this issue.

Adding devel to CI, fix #161, fix #149 pietroppeter/nimib
2 participants
@pietroppeter @HugoGranstrom