Add support for mouse wheel zoom #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilenns
commented
May 3, 2024
|
I'll admit, I am not a huge fan of this. Zooming in to the UI of a desktop application is clunky. Users will not that they accidentally zoomed in or a lot of cases, and will open issues "why is my UI zoomed in". I'd rather we properly support high DPI. |
Fair. Maybe just a setting for increased font size? Or maybe just make the font size bigger in mini mode? The main mode is fine honestly. |
|
Will open a different PR with just an increased font size per discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
Adds an event handler for the
zoom-changedevent and uses it to adjust the zoom level for the window contents, limited to between 100% and 300%.This applies to the entire window contents, so it does zoom the non-mini UI as well. I'm not aware of a way to only zoom if the mini content is what's shown.