Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show active receive in the mini view #25

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

neilenns
Copy link
Contributor

Fixes #24

Highlights the station name on Tx:

image

And the callsign on Rx:

image

@pierr3
Copy link
Owner

pierr3 commented Apr 30, 2024

Although your PR follows the design convention currently used, it might be more intuitive to highlight the callsign in green, to make a better difference between TX and RX in this limited UI, what do you think?

@neilenns
Copy link
Contributor Author

Although your PR follows the design convention currently used, it might be more intuitive to highlight the callsign in green, to make a better difference between TX and RX in this limited UI, what do you think?

I was originally going to do that to show Rx and highlight the whole line, then I realized I could highlight the two parts separately and just didn't think to use green for Rx. Can easily make that change, good suggestion.

@pierr3 pierr3 merged commit 3de202e into pierr3:main Apr 30, 2024
0 of 3 checks passed
@pierr3
Copy link
Owner

pierr3 commented Apr 30, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show active receive in the mini view
2 participants