Skip to content

Commit

Permalink
Fix OSX codesign
Browse files Browse the repository at this point in the history
  • Loading branch information
pierr3 committed May 9, 2024
1 parent f347488 commit 0ac60bf
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,13 @@ jobs:
# APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
run: npm run make -- --arch ${{ matrix.arch }}

- name: Codesign dmg
if: matrix.os == 'macos-latest'
run: |
cd out/make
dmg_file=$(find . -name "*.dmg" -type f)
codesign --timestamp --verbose --sign "Developer ID Application" $dmg_file
- name: Make AppImage
if: matrix.os == 'ubuntu-latest'
run: |
Expand All @@ -147,7 +154,7 @@ jobs:

- name: Upload artifacts
uses: softprops/action-gh-release@v2
if: matrix.os == 'windows-2019' && always()
if: matrix.os == 'windows-2019'
with:
tag_name: ${{ steps.relinfo.outputs.release }}
files: "out/make/**/*.exe"
Expand Down
9 changes: 1 addition & 8 deletions forge.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const config: ForgeConfig = {
packagerConfig: {
name: "TrackAudio",
asar: true,
osxSign: {},
icon: "resources/AppIcon/AppIcon",
extraResource: [
"resources/AC_Bus_f32.wav",
Expand All @@ -37,14 +38,6 @@ const config: ForgeConfig = {
name: "@electron-forge/maker-dmg",
config: {
icon: "resources/AppIcon/AppIcon.icns",
additionalDMGOptions: {
"code-sign": {
"signing-identity": "Developer ID Application",
},
},
packagerOptions: {
osxSign: {}
},
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0ac60bf

Please sign in to comment.