windows: fix WebViewEnvironment dispose crash #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not able to reproduce the issue, do you have a minimal code example to test? Thanks |
|
Ok it seems to be caused when a WebViewEnvironment is disposed while being used by a WebView. |
|
@all-contributors please add @GooRingX for code |
|
I've put up a pull request to add @GooRingX! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webViewEnvironment.dispose() will cause a wild pointer crash. The reason is that after WebViewEnvironment is destroyed, the event callbacks such as add_ProcessInfosChanged access the WebViewEnvironment this pointer, causing a wild pointer crash. Fix: Cancel the callback registration of related events during destruction