Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.3 - Pihole Admin deprecated php commands #3176

Closed
olli3 opened this issue Nov 24, 2024 · 3 comments
Closed

PHP8.3 - Pihole Admin deprecated php commands #3176

olli3 opened this issue Nov 24, 2024 · 3 comments

Comments

@olli3
Copy link

olli3 commented Nov 24, 2024

Versions

Pi-hole version is v5.18.3 (Latest: v5.18.3)
web version is v5.21-4-g5c8945c (Latest: v5.21)
FTL version is v5.25.2 (Latest: v5.25.2)

Platform

  • OS and version: Debian GNU/Linux 11 (bullseye)

Expected behavior

A clear and concise description of what you expected to happen.

PHP8.3 many deprecated php commands including utf8_encode

Actual behavior / bug

admin interface is broken due to often bad JSON going to datatables because of php warnings / deprecation errors (if on on server)

Steps to reproduce

Steps to reproduce the behavior:

  1. upograde to php8.3
  2. login and navigate to admin pages

FILES CHANGED LOCALLY TO FIX - changed utf_encode) to mb_convert_encoding(VAR, 'UTF-8', 'ISO-8859-1')

modified:   api_FTL.php
modified:   api_db.php
modified:   composer.lock
modified:   scripts/pi-hole/php/auth.php
modified:   scripts/pi-hole/php/groups.php

=

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

@yubiuser
Copy link
Member

With the upcoming Pi-hole version 6 PHP is gone.

@rdwebdesign
Copy link
Member

As explained by yubiuser, the current version in development doesn't use PHP and the PHP code probably won't be fixed.

As a temporary fix, you can hide the PHP deprecation messages in your system adding & ~E_DEPRECATED to error_reporting in your php.ini, like this:

error_reporting = E_ALL & ~E_STRICT & ~E_DEPRECATED

@olli3
Copy link
Author

olli3 commented Nov 24, 2024

@both acknowledged and thanks

I’ve fixed the php code myself instead of disabling the messages in my server .. I’d rather see them myself …

Look forward to the new version

Keep it real out there

O

@olli3 olli3 closed this as completed Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants