Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better alert messages for DHCP Static Lease editing #2446

Closed
wants to merge 1 commit into from

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Dec 3, 2022

What does this PR aim to accomplish?:

Fix #2445

How does this PR accomplish the above?:

Changing how the Static DHCP Leases are handled.

Currently, clicking on the add or delete buttons triggers a HTML form POST. This action always reloads the page.
Creating an ajax call via javascript will avoid the reload and will allow the use of the utils.showAlert() function (or something similar).
To achieve this, the code to Add and Delete static leases will need to be moved from savesettings.php to api.php.
2 new endpoints will be created on api.php.

Warning:
I didn't have time to finish this PR yet. The current code is incomplete.

Link documentation PRs if any are needed to support this PR:
none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review.

@rdwebdesign rdwebdesign marked this pull request as draft December 3, 2022 04:52
@yubiuser yubiuser linked an issue Dec 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tracking] Bad placement of alerts on DHCP Settings.
1 participant