Better alert messages for DHCP Static Lease editing #2446
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Fix #2445
How does this PR accomplish the above?:
Changing how the Static DHCP Leases are handled.
Currently, clicking on the add or delete buttons triggers a HTML form POST. This action always reloads the page.
Creating an
ajax
call via javascript will avoid the reload and will allow the use of theutils.showAlert()
function (or something similar).To achieve this, the code to Add and Delete static leases will need to be moved from
savesettings.php
toapi.php
.2 new endpoints will be created on
api.php
.Warning:
I didn't have time to finish this PR yet. The current code is incomplete.
Link documentation PRs if any are needed to support this PR:
none
By submitting this pull request, I confirm the following:
git rebase
)