Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to support numpy >= 1.24 #434

Open
smoia opened this issue Dec 20, 2022 · 0 comments
Open

Update code to support numpy >= 1.24 #434

smoia opened this issue Dec 20, 2022 · 0 comments
Labels
Bug Something isn't working Enhancement New feature or request Hacktoberfest Issue/PR for hacktoberfest. Completing this issue/PR might not grant the all-contributor recognition Refactoring Improve nonfunctional attributes

Comments

@smoia
Copy link
Member

smoia commented Dec 20, 2022

Summary

Tests in #424 were failing for python 3.10 due to some incompatibility between our code and numpy >=1.24 (see here). Versions of numpy <1.24 did not raise the same issue.
At the moment, the issue is "fixed" by declaring a required numpy version below 1.24, but a more permanent fix should be developed.

Additional detail

Next Steps

* Check failing tests with numpy 1.24 or above
* Check the reason for failure, comparing it with numpy's changelog
* Update the code to be compatible with numpy 1.24 and above
@smoia smoia added Bug Something isn't working Enhancement New feature or request Hacktoberfest Issue/PR for hacktoberfest. Completing this issue/PR might not grant the all-contributor recognition Refactoring Improve nonfunctional attributes labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request Hacktoberfest Issue/PR for hacktoberfest. Completing this issue/PR might not grant the all-contributor recognition Refactoring Improve nonfunctional attributes
Projects
None yet
Development

No branches or pull requests

1 participant