Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refurb back to QA checks #348

Closed
3 tasks done
maxrake opened this issue Nov 13, 2023 · 1 comment
Closed
3 tasks done

Add refurb back to QA checks #348

maxrake opened this issue Nov 13, 2023 · 1 comment
Labels
task Task/chore unrelated to a bug or feature request

Comments

@maxrake
Copy link
Contributor

maxrake commented Nov 13, 2023

Description

With recent releases of refurb and mypy, the refurb QA check started to fail with an error:

interpreted classes cannot inherit from compiled traits

This error is unrelated to phylum-ci and has been documented in dosisod/refurb#305

This issue is to re-enable the refurb QA checks once the referenced bug has been resolved.

Additional Details

Attempting to downgrade/pin the use of refurb and/or mypy did not work.

Acceptance Criteria

  • The refurb QA check is added back to .pre-commit-config.yaml
  • The --repo https://github.com/dosisod/refurb \ entry is added back to .github/workflows/auto_updates.yml for updating the hook
  • TODO: entries are removed from the code
@maxrake maxrake added the task Task/chore unrelated to a bug or feature request label Nov 13, 2023
maxrake added a commit that referenced this issue Nov 13, 2023
@maxrake
Copy link
Contributor Author

maxrake commented Nov 13, 2023

Closing this now that dosisod/refurb#305 has been resolved and included in a new release of refurb (v1.23.0).

@maxrake maxrake closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task/chore unrelated to a bug or feature request
Projects
None yet
Development

No branches or pull requests

1 participant