Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup temporary test directories #66

Closed
kylewillmon opened this issue Nov 29, 2023 · 0 comments · Fixed by #67
Closed

Cleanup temporary test directories #66

kylewillmon opened this issue Nov 29, 2023 · 0 comments · Fixed by #67
Assignees
@cd-work

Comments

@kylewillmon
Copy link
Contributor

Many of the integration tests currently leak temporary directories (because they can't be removed once the sandbox is in place). With the new test harness in #64, we can now clean these up. See this discussion.
@kylewillmon kylewillmon mentioned this issue Nov 29, 2023
Merged
cd-work added a commit that referenced this issue Nov 30, 2023
@cd-work
Fix tests leaking symlinks
a3f96bb 
This patch changes our test handling so ZERO temporary files are leaked
to the filesystem after running Birdcage's tests.

Closes #66.
@cd-work cd-work mentioned this issue Nov 30, 2023
Merged
@cd-work cd-work self-assigned this Nov 30, 2023
cd-work added a commit that referenced this issue Nov 30, 2023
@cd-work
Fix tests leaking symlinks (#67)
18f2a8c 
This patch changes our test handling so ZERO temporary files are leaked
to the filesystem after running Birdcage's tests.

Closes #66.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cd-work cd-work

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests leaking symlinks phylum-dev/birdcage
2 participants
@kylewillmon @cd-work