Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spot-check of scaling accuracy #316

Closed
arlin opened this issue Jun 21, 2018 · 5 comments
Closed

spot-check of scaling accuracy #316

arlin opened this issue Jun 21, 2018 · 5 comments
Assignees

Comments

@arlin
Copy link
Member

arlin commented Jun 21, 2018

The dev portal currently allows median-scaled trees from DateLife. These are shown with a scalebar in millions of years. We haven't tested yet whether these values are correct. They might be mistaken if there are mistakes in the code.

Pick a case such as felidae for which we know the dates expected from DateLife resources, and use this to test whether the dev portal is representing dates accurately for a median scaled tree.

Another way to test is to use TimeTree. Download a list from the portal, upload it in TimeTree, which accepts the one-name-per-line format.

@arlin arlin added this to the Phylotastic general manuscript milestone Jun 21, 2018
@arlin
Copy link
Member Author

arlin commented Jul 6, 2018

I'm checking this using the desert plants list. Note that TimeTree cannot find about 12 of the species out of 15, so I can't use TimeTree to check this. Waiting for feedback from @LunaSare

@arlin
Copy link
Member Author

arlin commented Jul 6, 2018

Cat family. Start with Stephen J O'Brien paper in Sci. American. http://www.bio-nica.info/biblioteca/O'brien2007EvolutionCats.pdf.
Screen Shot 2018-07-06 at 4.05.14 PM.png

@arlin
Copy link
Member Author

arlin commented Jul 7, 2018

OK, I have now done a comparative analysis of scaling for Felidae. The results are here: https://www.dropbox.com/sh/lx7xf0bdw1z88ah/AAC7hJoVjnDAGpskuxJ5S9Ica?dl=0

felidae_scaling.png

@LunaSare
Copy link
Member

I finished trying both felidae and desert plants examples and some others from the lists available on phylotastic portal.
median and sdm trees displayed on the portal come from using a tree as input. When using names as input, results are different. That's why my tests and the portal trees were different. Please see issue #322

@arlin
Copy link
Member Author

arlin commented Jul 12, 2018

Our analysis of this yesterday and today is that the Felidae results are acceptable given that there is disagreement among the published chronograms, and disagreement among scientists. We just need to do some things to notify the user about this: see #323

@arlin arlin closed this as completed Jul 12, 2018
@arlin arlin removed the in progress label Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants