Upgrade base image to phusion/baseimage:noble-1.0.0 #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajhodgson
force-pushed
the
ajhodgson/upgrade-to-noble
branch
from
bd56cf7 to
f18337a
Compare
| ## | ||
|
|
||
| access_log /var/log/nginx/access.log; | ||
| error_log /var/log/nginx/error.log; |
There was a problem hiding this comment.
is it falling back to STDOUT by default ? why this change?
There was a problem hiding this comment.
It still sets error_log /var/log/nginx/error.log; - it just does it at the root scope now.
You can look at phusion/passenger#2541 for why.
There is no change in behaviour here.
Make Python 3.12 the default python version
during image build.
ajhodgson
force-pushed
the
ajhodgson/upgrade-to-noble
branch
from
fc4a44c to
32f28b3
Compare
|
github was being dumb about merging this so I did it on the cli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the minor issues I found and noted significant user-affecting changes in CHANGELOG.md.
I have built all variants of the image and verified that the correct interpreter versions are installed in each.
I tested 2 Rails apps and 2 python apps on versions of this container (amd64 only).
Review and further testing recommended.