Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme color issue #1

Open
amitschandillia opened this issue Apr 17, 2019 · 1 comment
Open

Theme color issue #1

amitschandillia opened this issue Apr 17, 2019 · 1 comment

Comments

@amitschandillia
Copy link

This boilerplate defines a default theme color palette as purple for primary and green for secondary. However, it doesn't define anything explicitly for the button text color. By default, all button text should be white, but when rendered, this code shows a purple button with black text. My question is, why is it changing the default text color for buttons and where in the code can I set it to white?

Also, when I disable the palette definitions section in getPageContext.js:

const theme = createMuiTheme({
    palette: {
        // primary: {
        //     light: lightBlue[300],
        //     main: lightBlue[500],
        //     dark: lightBlue[700],
        // },
        // secondary: {
        //     light: pink[300],
        //     main: pink[500],
        //     dark: pink[700],
        // },
    },
});

I get the primary button in indigo instead of the expected default of lightBlue. I tried looking through the entire codebase but couldn't spot this definition anywhere!

@phuongnq
Copy link
Owner

Default theme seems only support from material-ui@v4 so I upgraded that package to 4.0.0-alpha.8. There are some change in source code as well. You can clone and check again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants