| Category | View Point | Description | Expected Reviewer Answer | Self review | Reviewer2 (name) |
|---|---|---|---|---|---|
| Conventions | Does the code follow Sun* coding style and coding conventions? | https://github.com/framgia/coding-standards/tree/master/eng/android | YES | ||
| Redmine | Does the ticket follow Sun* Redmine working process? | https://github.com/framgia/Training-Guideline/blob/master/WorkingProcess/redmine/redmine.md | YES | ||
| Documentation | Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’? | YES |
(Impacted Areas in Application(List features, api, models or services that this PR will affect))
(List gem, library third party add new)
(Other notes)