Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, I refactored the whole code #3

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Jul 26, 2017

Every application is the same as your purpose.
This code is runnable on tensorflow 1.2

I removed the unused variables, fixed some minor errors, and simplified the code, and added many comments to understand easily.

The only thing I omitted is the usage of tensorboard. Actually I don't like it, but just kept the pictures on README.md

This kind of code is just my style. I hope you like it.

@phreeza
Copy link
Owner

phreeza commented Jul 26, 2017

Hey this looks great, thanks. I am a bit busy at the moment but I will have a look over the PR as soon as I get a chance. Just out of curiosity, what are you using the vrnn for?

@ghost
Copy link
Author

ghost commented Jul 28, 2017

During searching of MANN(memory augmented neural network), I read some papers about GTMM(generative temporal model with memory). This model applied VAE+RNN+Memory at the same time. To understand this topic fully, I studied about VRNN(VAE+RNN). Ur code was really helpful for me to understand. I'm looking forward to finding some models to catch detect images with defect, when some kinds of images come in series.

@diegoroman17
Copy link

Hello, Thank you for share your code. I am understanding VRNN using it. Please help me with 2 specific questions:

  1. What is the chunk_samples parameters and why the 3 dimension of the input and output has only 0's.
  2. The code is testing for 1-D time series, but could it work for 10-D time-series?
    Thank you in advance

@diegoroman17
Copy link

Another question is about the use of inputs and targets. On the original paper they reconstruct xt but in your code the target is xt+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants