Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen constraints for ss3 projects #13

Open
bumbus opened this issue Apr 25, 2018 · 3 comments
Open

Loosen constraints for ss3 projects #13

bumbus opened this issue Apr 25, 2018 · 3 comments

Comments

@bumbus
Copy link

bumbus commented Apr 25, 2018

Hi there,
may i ask if you could loosen the php constraints ( at the moment >=5.4,<7), so it is possible to run silverstripe 3 projects in php7.

"php": ">=5.4,<7",

I gave it a test with (php 7.0.27) https://github.com/arillo/silverstripe-jsontext/tree/dev and it did work.

@phptek
Copy link
Owner

phptek commented Apr 29, 2018

@bumbus Thanks for this. I have created a new 3-series integration branch "3.x" and patched it as per your request. Can you please check this branch out, and run the unit-test suite across it in PHP7.0.27? :-)

@bumbus
Copy link
Author

bumbus commented Apr 30, 2018

@phptek thank you for looking into this. I gave it a test run. Basically it looks ok, but somehow there seem to be some problems with the way the tests are written:

$ sake dev/tests/module/jsontext/
ALL TESTS
Running test cases:
--------------------
jsontextbasictest, jsontextextensiontest, jsontextintegrationtest, jsontextquerytest,
jsontextsetvaluetest, jsontexttest

..E
JSONTextBasicTest::testLast
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,33.3333)
JSONTextBasicTest.php:116

--------------------
.F
JSONTextExtensionTest::testExceptionThrownOnBeforeWrite
Failed asserting that exception of type "\JSONText\Exceptions\JSONTextException" is thrown.
--------------------
..E
JSONTextQueryTest::testQueryWithMatchOnInt
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,44.6)
JSONTextQueryTest.php:83

--------------------
E
JSONTextQueryTest::testQueryWithMatchOnStr
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,99.99)
JSONTextQueryTest.php:184

--------------------
E
JSONTextQueryTest::testQueryWithMatchOnPath
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,99.99)
JSONTextQueryTest.php:311

--------------------
.......E
JSONTextTest::testToSSTypes
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,33.3333)
JSONTextTest.php:103

--------------------


 AT LEAST ONE FAILURE

18 tests run: 12 passes, 6 failures, and 0 incomplete
Maximum memory usage: 54.0M

@phptek
Copy link
Owner

phptek commented May 1, 2018

Weird. Which version of phpunit are you using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants