-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix certain PR checks that always fail #997
Comments
yes, that's why they are marked to "allow to fail". They fail on composer dependencies. We'll take them out soon |
Where does it show "allow to fail"? |
Do only admins see it? |
Ah, don't know. Can you see it here? https://github.com/phpList/phplist3/actions/runs/6760239013 Also, the overall run has a blue tick, as opposed to a red one when all of them fail https://github.com/phpList/phplist3/actions |
Some actions there have a fail icon and some "just" a warning. In #994 for example to know it's okay not to pass some of these tests? |
This is now ready for review in #1004 |
If someone tries to send a PR to your code, two commit checks always fail.
Steps to reproduce
Expected result
Pass all checks.
Actual outcome
The second and third checks from the end (7.2 and 7.3) always fail.
You can see them for further details in every open PR. The important part is it has nothing to do with the PR, but presented like it is (unless one clicks Details and reads carefully).
The text was updated successfully, but these errors were encountered: