ISSUE-337: fix phpmd

phpList · Dec 9, 2024 · 822d258 · 822d258
1 parent 9658c6c
commit 822d258
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/src/Core/Bootstrap.php b/src/Core/Bootstrap.php
@@ -54,6 +54,8 @@ class Bootstrap
      */
     private ApplicationStructure $applicationStructure;
 
+    private ErrorHandler $errorHandler;
+
     /**
      * Protected constructor to avoid direct instantiation of this class.
      *
@@ -62,6 +64,7 @@ class Bootstrap
     protected function __construct()
     {
         $this->applicationStructure = new ApplicationStructure();
+        $this->errorHandler = new ErrorHandler();
     }
 
     /**
@@ -219,7 +222,7 @@ public function dispatch()
     private function configureDebugging(): Bootstrap
     {
         if ($this->isDebugEnabled()) {
-            ErrorHandler::register();
+            $this->errorHandler->register();
         }
 
         return $this;

diff --git a/src/Domain/Repository/Identity/AdministratorRepository.php b/src/Domain/Repository/Identity/AdministratorRepository.php
@@ -20,11 +20,11 @@ class AdministratorRepository extends AbstractRepository
     private HashGenerator $hashGenerator;
 
     public function __construct(
-        EntityManagerInterface $em,
+        EntityManagerInterface $entityManager,
         ClassMetadata $class,
         HashGenerator $hashGenerator = null
     ) {
-        parent::__construct($em, $class);
+        parent::__construct($entityManager, $class);
         $this->hashGenerator = $hashGenerator ?? new HashGenerator();
     }
 

diff --git a/src/TestingSupport/Traits/SymfonyServerTrait.php b/src/TestingSupport/Traits/SymfonyServerTrait.php
@@ -19,8 +19,8 @@ trait SymfonyServerTrait
     private ?Process $serverProcess = null;
 
     private static string $lockFileName = '.web-server-pid';
-    private static int $maximumWaitTimeForServerLockFile = 5000000;
-    private static int $waitTimeBetweenServerCommands = 50000;
+    private static int $lockWaitTimeout = 5000000;
+    private static int $serverCommandTimeout = 50000;
 
     private static ?ApplicationStructure $applicationStructure = null;
 
@@ -46,9 +46,9 @@ protected function startSymfonyServer(): void
         );
         $this->serverProcess->start();
 
-        usleep(self::$waitTimeBetweenServerCommands);
+        usleep(self::$serverCommandTimeout);
         $this->waitForServerLockFileToAppear();
-        usleep(self::$waitTimeBetweenServerCommands);
+        usleep(self::$serverCommandTimeout);
     }
 
     private function lockFileExists(): bool
@@ -73,7 +73,7 @@ protected function getBaseUrl(): string
     private function waitForServerLockFileToAppear(): void
     {
         $currentWaitTime = 0;
-        while (!$this->lockFileExists() && $currentWaitTime < self::$maximumWaitTimeForServerLockFile) {
+        while (!$this->lockFileExists() && $currentWaitTime < self::$lockWaitTimeout) {
             $process = new Process(['symfony', 'server:status', '--no-ansi']);
             $process->run();
 
@@ -84,8 +84,8 @@ private function waitForServerLockFileToAppear(): void
                     file_put_contents(self::$lockFileName, trim($port));
                 }
             }
-            usleep(self::$waitTimeBetweenServerCommands);
-            $currentWaitTime += self::$waitTimeBetweenServerCommands;
+            usleep(self::$serverCommandTimeout);
+            $currentWaitTime += self::$serverCommandTimeout;
         }
 
         if (!$this->lockFileExists()) {