Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Foreground indicator fixed for VoIP notifications #2728

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jlorente
Copy link
Contributor

Foreground indicator fixed for VoIP notifications

Description

Foreground attribute in additionaData payload was always false for VoIP notifications. With this
fix, it takes the properly value.

Related Issue

#2368

How Has This Been Tested?

With Xcode 10.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jlorente
Copy link
Contributor Author

I have seen the error in the tests, but I have not changed the js code.

@jlorente
Copy link
Contributor Author

jlorente commented Sep 26, 2019

I have merged the latests commits of the repository and now the tests have passed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants