Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support {...} interpolation in body #3514
base: main
Are you sure you want to change the base?
Support {...} interpolation in body #3514
Changes from 5 commits
08de7f3
1f6bdd8
593bab2
279e452
1312a2c
fd375e8
768b043
3b53d8c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the EEx syntax is going away it seem odd to keep it around just for comment tags. Why not a
{% %}
style?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not going away though, it is not possible to do
{if ... do}
,{for ... do}
, etc. (Not that people should reach for those given :if and :for exists.) We can't use{...}
interpolation inside<script>
and<style>
either and for that<%= ... %>
is the way to go.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The EEx syntax is not going away per se because it is still needed in some situations (such as inside script, style, and template, as escaping
{
in there would be a pain) but I agree we should probably consider introducing something specific for comments later on.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
<%!-- --%>
comment syntax was inspired by Surface's{!-- --}
. If we're moving to curly braces in the HTML, I'd vote we use the curly comments too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for
{!-- --}
style