Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed 2 lines that are redundant anyways (please verify) #2764

Closed
wants to merge 2 commits into from
Closed

removed 2 lines that are redundant anyways (please verify) #2764

wants to merge 2 commits into from

Conversation

Dorfeuheinz
Copy link
Contributor

No description provided.

@Dorfeuheinz Dorfeuheinz reopened this Aug 12, 2023
@josevalim
Copy link
Member

Hi @Dorfeuheinz! I prefer to keep it as is because, if we later change normalize_layout to behave differently, then this code won't update it in place. In other words, you are removing unnecessary logic but at the same it means the caller needs to be more aware of what the callee does. :)

@josevalim josevalim closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants