Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload: lack of documentation (or support) for passing errors from :external 2-arity function #3369

Open
DaTrader opened this issue Jul 25, 2024 · 0 comments

Comments

@DaTrader
Copy link

DaTrader commented Jul 25, 2024

Environment

  • Phoenix version (mix deps): 0.20.17

Actual behavior

Upload config: external, autoload

I couldn't find any documentation on what the :external 2-arity function is supposed to return in the meta map in { :error, meta, socket} for the error to end up in the UploadConfig structure i.e. to become retrievable with Phoenix.Component.upload_errors.

Has this feature been developed yet or is planned to be developed or it's completely up to developers to handle such errors separately from the predefined upload ones?

Expected behavior

There should be a word in the docs on how to deal with those errors now and in the future.

PS. It would also be great if the value provided to entry.error/1 in a JS uploader was actually propagated along or instead of the external_client_failure atom.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant