Update :text column to textarea to match intent for html generator

[lifeiscontent]

No description provided.

[ShPakvel]

Thank you for catch. 🙇🏼

[SteffenDE]

Hi @lifeiscontent,

I'm not sure if we can really assume that users that specify text as column type also want a textarea necessarily? In any case we'd need to have the same behavior in the phx.gen.live generator as well.

It is also really not a big change to do yourself after running the generator. Let's see what others think :)

[ShPakvel]

@lifeiscontent +1 from my side on similar update for live form. And also I suggest to update this test with additional text field, to check textarea input in this form assertion.

@SteffenDE, regarding choice between input and textarea. Usually type string associated with input in html, and type text associated with textarea in html, as text type chosen for databases usually means "we expect lot more words to store here". I believe it is general practical approach to map html-to-db this way.

[lifeiscontent]

@ShPakvel yep, my thoughts exactly. I'll try to follow up on this PR over the weekend. :)

[josevalim]

Yes, text is meant to be translated to textarea, otherwise use string. 👍

[lifeiscontent]

alright, all updated, including tests! Thanks for the support guys :)

[SteffenDE]

@lifeiscontent I don't see phx.gen.live being updated?

see

phoenix/lib/mix/tasks/phx.gen.live.ex

Lines 287 to 288 in dad4527

	{key, :text} ->
	~s(<.input field={@form[#{inspect(key)}]} type="text" label="#{label(key)}" />)

[lifeiscontent]

@SteffenDE I'm not sure what happened, but it appears my work went missing during tranmission, all fixed now 😅

[lifeiscontent]

@SteffenDE bump

[SteffenDE]

Thanks for bumping! 🙌🏻