Updates the deploy guide to what worked with Phoenix and Liveview as … #5558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of today
Fix for issue
#5557
The deploy guide for Heroku is not 100% accurate anymore.
I followed them the best I could but a couple things just did not work correctly.
I could not deploy to
master
as Heroku is usingmain
now for Git.Once deployed web sockets would not connect.
I added the
PHX_HOST
env var and that resolved it.The
PHX_HOST
issue may be a deeper issue with the config recommendations for adding the host.That part did seem to not 100% reflect the current state of a new Phoenix application for 1.7.7
The setting the env var may be a band-aid.
If anyone has more insight into that please let me know and I will make changes to this PR.
The example app I tested with: https://github.com/tapickell/url_short_link