Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition #17

Open
ShahimEssaid opened this issue Oct 28, 2020 · 2 comments
Open

Condition #17

ShahimEssaid opened this issue Oct 28, 2020 · 2 comments
Labels
domain A tag for domain related issues regardless of their representation in models.

Comments

@ShahimEssaid
Copy link
Member

Discussion thread for page: https://phenopackets-analysis.readthedocs.io/en/latest/domain-entities/condition.html

@ShahimEssaid ShahimEssaid added the domain A tag for domain related issues regardless of their representation in models. label Oct 28, 2020
@pnrobinson
Copy link
Collaborator

It seems Disease can easily be modeled as a FHIR Condition

Disease.term = Condition.code
Disease.onset = Condition.onset
Disease.disease_stage = Condition.stage

The v1 phenopacket has a fourth element, tnm_finding. However, it seems that this could be subsumed under disease_stage and it was perhaps a mistake to include this element. Therefore, I would suggest for our IG that we model just the first three elements of Disease as a Condition. @ShahimEssaid

@pnrobinson
Copy link
Collaborator

@ShahimEssaid it seems that we only need to require that the Condition use an ontology term to describe the disease. The default is a 0..1 cardinality. So I think that all we need to do is to stipulate that the cardinality is 1..1.
The Phenopacket fields for disease onset and stage are optional, and so for the IG, I do not think that we need to make them required.
There is another question of how to translate disease codes into codes that can be used for rare disease genomics, and so if we wanted to, we could stipulate a code set using MONDO. But knowing the disease is not required for exome diagnostics if we have phenotypes, and if we knew the exact disease, we would not be doing diagnostics. I will make a PR for the SturcutreDefinition of disease -- I think we can keep it simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain A tag for domain related issues regardless of their representation in models.
Projects
None yet
Development

No branches or pull requests

2 participants