-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto tab spacing detection #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Quality Gate passedIssues Measures |
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect Indents automatically based on current file
This will be the default mode. This can be toggled from the status bar by using the fixed/Auto toggle as shown below.
features
auto
toggle in status bar twice. (to change mode to fixed and back to auto will recompute the spacing for the current file). Not entirely intuitive, but should be a very rare use case and didnt wanted to complicate the ui with more options and dropdows like in other editors."autoTabSpaces" : true
- to enableHow it works
We use a modified version of https://www.npmjs.com/package/detect-indent . On creating a new editor, we scan the first 700 lines of text to determine the most probable indentation for the current editor.
700 lines was selected as it should be large enough to account for file comment headers if any and then we performance analysis and it takes <0.1 ms in most cases to scan 700 lines. Further, we modified the lib to directly use our editor APIs to get lines instead of getting text from the edtor as a whole and then splitting lines to improve perfomance.
The spacing computed for the file is cached temporarily for the current session and will be reused to reduce file switch times.