Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better robustness for triple control key press detect and disable preference #1779

Merged
merged 2 commits into from
Jul 26, 2024
Merged

chore: better robustness for triple control key press detect and disable preference #1779

merged 2 commits into from
Jul 26, 2024

Conversation

abose
Copy link
Member

@abose abose commented Jul 26, 2024

Address: https://www.reddit.com/r/brackets/comments/1eam4vq/comment/leymxt4/?context=3

  • Changed triple key detect algorithm to be more robust to prevent accidental engagement of the visual command palette ui
  • Also added preference tripleCtrlPalette: true/false to enable/disable feature

@phoenixide
Copy link
Member

Thank You for making this pull request.

@phoenixide
Copy link
Member

Thank You for making this pull request.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@abose abose merged commit 99d32f4 into main Jul 26, 2024
16 of 17 checks passed
@abose abose deleted the p branch July 26, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abose @phoenixide