From e0735bef03e4ab6c3b1724a97dea4ffb42900214 Mon Sep 17 00:00:00 2001 From: abose Date: Sat, 7 Dec 2024 11:59:15 +0530 Subject: [PATCH] refactor: remove redundant code as build already does lint --- .github/workflows/minor-version-bump.yml | 1 - .github/workflows/patch-version-bump.yml | 1 - .github/workflows/yearly-major-version-bump.yml | 1 - .husky/pre-push | 5 ----- 4 files changed, 8 deletions(-) diff --git a/.github/workflows/minor-version-bump.yml b/.github/workflows/minor-version-bump.yml index 77b02acb8..419020422 100644 --- a/.github/workflows/minor-version-bump.yml +++ b/.github/workflows/minor-version-bump.yml @@ -22,7 +22,6 @@ jobs: git status phoenix_version=`node -p "require('./package.json').apiVersion"` echo "PHOENIX_VERSION=${phoenix_version}" >> $GITHUB_ENV - echo "SKIP_TEST_RUN_GITHUB=yes" >> $GITHUB_ENV shell: bash - name: Create Bump patch version Pull Request diff --git a/.github/workflows/patch-version-bump.yml b/.github/workflows/patch-version-bump.yml index f07e03159..f96373013 100644 --- a/.github/workflows/patch-version-bump.yml +++ b/.github/workflows/patch-version-bump.yml @@ -22,7 +22,6 @@ jobs: git status phoenix_version=`node -p "require('./package.json').apiVersion"` echo "PHOENIX_VERSION=${phoenix_version}" >> $GITHUB_ENV - echo "SKIP_TEST_RUN_GITHUB=yes" >> $GITHUB_ENV shell: bash - name: Create Bump patch version Pull Request diff --git a/.github/workflows/yearly-major-version-bump.yml b/.github/workflows/yearly-major-version-bump.yml index cd30de374..115e39e40 100644 --- a/.github/workflows/yearly-major-version-bump.yml +++ b/.github/workflows/yearly-major-version-bump.yml @@ -19,7 +19,6 @@ jobs: git status phoenix_version=`node -p "require('./package.json').apiVersion"` echo "PHOENIX_VERSION=${phoenix_version}" >> $GITHUB_ENV - echo "SKIP_TEST_RUN_GITHUB=yes" >> $GITHUB_ENV shell: bash - name: Create Bump patch version Pull Request diff --git a/.husky/pre-push b/.husky/pre-push index 3f3bfa6ab..6e71d16a9 100755 --- a/.husky/pre-push +++ b/.husky/pre-push @@ -2,8 +2,3 @@ . "$(dirname "$0")/_/husky.sh" npm run build -if [ -z "${SKIP_TEST_RUN_GITHUB}" ]; then - npm run lint -else - echo "skipping test run as GitHub Actions environment test run skip is set" -fi