From 61d1694b64f4d27216857166ed25ab26d8a83aff Mon Sep 17 00:00:00 2001
From: abose <arun@core.ai>
Date: Thu, 11 Jan 2024 19:43:27 +0530
Subject: [PATCH] chore: reverse highlight should also be disabled when live
 preview highlight feature deisabled

---
 .../MultiBrowserImpl/protocol/LiveDevProtocol.js            | 6 ++++++
 src/phoenix/shell.js                                        | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/src/LiveDevelopment/MultiBrowserImpl/protocol/LiveDevProtocol.js b/src/LiveDevelopment/MultiBrowserImpl/protocol/LiveDevProtocol.js
index db96a2a37..9ac87998c 100644
--- a/src/LiveDevelopment/MultiBrowserImpl/protocol/LiveDevProtocol.js
+++ b/src/LiveDevelopment/MultiBrowserImpl/protocol/LiveDevProtocol.js
@@ -47,6 +47,7 @@ define(function (require, exports, module) {
         RemoteFunctions       = require("text!LiveDevelopment/BrowserScripts/RemoteFunctions.js"),
         EditorManager         = require("editor/EditorManager"),
         LiveDevMultiBrowser   = require("LiveDevelopment/LiveDevMultiBrowser"),
+        PreferencesManager  = require("preferences/PreferencesManager"),
         HTMLInstrumentation   = require("LiveDevelopment/MultiBrowserImpl/language/HTMLInstrumentation"),
         StringUtils = require("utils/StringUtils"),
         FileViewController    = require("project/FileViewController");
@@ -94,6 +95,11 @@ define(function (require, exports, module) {
     }
 
     function _tagSelectedInLivePreview(tagId) {
+        const highlightPref = PreferencesManager.getViewState("livedev.highlight");
+        if(!highlightPref){
+            // live preview highlight and reverse highlight feature is disabled
+            return;
+        }
         const liveDoc = LiveDevMultiBrowser.getCurrentLiveDoc(),
             editor = EditorManager.getActiveEditor();
         const liveDocPath = liveDoc ? liveDoc.doc.file.fullPath : null,
diff --git a/src/phoenix/shell.js b/src/phoenix/shell.js
index 3ca684135..9eb3a1ec0 100644
--- a/src/phoenix/shell.js
+++ b/src/phoenix/shell.js
@@ -118,6 +118,9 @@ Phoenix.app = {
         return window.Strings.STORED_IN_YOUR_BROWSER;
     },
     getDisplayPath: function (fullOrRelativeVFSPath) {
+        if(!fullOrRelativeVFSPath){
+            return "";
+        }
         // reruns a path that can be shown to the user to make some sense of the virtual file path.
         // The returned path is platform path for tauri,
         // a relative path of the form (folder/file.txt) starting with opened folder name for fs access- /mnt/paths