Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

MAINTAINED FORK: K-and-R/easy_captcha (gem kandr-easy_captcha) #36

Open
karlwilbur opened this issue Dec 5, 2020 · 7 comments
Open

Comments

@karlwilbur
Copy link

karlwilbur commented Dec 5, 2020

I have forked this and am working to improve its code quality and test coverage, as well as address some of the issues.

https://github.com/K-and-R/easy_captcha

https://rubygems.org/gems/kandr-easy_captcha

As my fork is a fork, I cannot create issues there. I wish to keep it as a connected fork rather than delete the fork and recreate it as a separately cloned repo.

Should anyone have any changes that are needed, please feel free to tag me or message directly.

@kopylovvlad
Copy link

Great idea! Previously I created a fork with Rails5 support link. But unfortunately, the original maintainer of this gem is not involved anymore.

@karlwilbur
Copy link
Author

Yes, I went through and merged many of the outstanding pull requests here. I merged your PR here: K-and-R@664bac2

@kopylovvlad
Copy link

Awesome! Do you have troubles with rmagick version 4.2.2? Today I merged little improvement from @BBenni

@karlwilbur
Copy link
Author

I don't recall specifically having trouble with RMagick. I did merge in quite a few different things and made several update/changes of my own. Tests are passing and I've been working on adding more.

@BBenni
Copy link

BBenni commented May 7, 2021

Yes the problem does not arise in the K-and-R fork as it uses a different implementation at the method in question than your fork @kopylovvlad .

In general: Thanks a lot for your work @kopylovvlad and @karlwilbur!

@BBenni
Copy link

BBenni commented May 7, 2021

K-and-R fork works very fine for me as is, except if I use caching.

If I use caching I get the following error:

 Exception: ArgumentError: wrong number of arguments (given 1, expected 0)
/usr/local/bundle/gems/kandr-easy_captcha-0.11.0/lib/easy_captcha/controller_helpers.rb:35:in `captcha_cache_path'

After a quick look it seems that there is indeed a problem in ControllerHelpers:

In the method cache_image you are calling captcha_cache_path with argument code (https://github.com/K-and-R/easy_captcha/blob/master/lib/easy_captcha/controller_helpers.rb#L130).

captcha_cache_path does however not take any arguments (https://github.com/K-and-R/easy_captcha/blob/master/lib/easy_captcha/controller_helpers.rb#L35).

@karlwilbur
Copy link
Author

@BBenni Thanks. I'll look into that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants