Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Composer dev dependencies from package output #289

Closed
arithmetric opened this issue Jun 21, 2016 · 4 comments
Closed

Remove Composer dev dependencies from package output #289

arithmetric opened this issue Jun 21, 2016 · 4 comments

Comments

@arithmetric
Copy link
Collaborator

When a Composer based build is packaged, development dependencies in composer.json should be excluded from the vendor resources included in the package output.

Follow up from #284.

@jhedstrom
Copy link
Member

We should also regenerate the autoload files so they don't include the dev dependencies. This may be automatically done depending on how we remove them (otherwise composer dump-autoload --no-dev would do it).

@grayside
Copy link
Contributor

If we end up running dump-autoload for a package, should we also run with --optimize?

This still leads to pushing the dev dependencies, I found composer remove --update-no-dev as a possibility, though I haven't tested to see if that's frustratingly slow.

@jhedstrom
Copy link
Member

In manual testing, running composer install --no-dev works, and is super fast. We could run this after packaging so as not to change the local install.

@jhedstrom
Copy link
Member

This is merged now.

unrblt pushed a commit to unrblt/grunt-drupal-tasks that referenced this issue Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants