Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing vendor path for package output #288

Closed
arithmetric opened this issue Jun 21, 2016 · 4 comments
Closed

Allow changing vendor path for package output #288

arithmetric opened this issue Jun 21, 2016 · 4 comments

Comments

@arithmetric
Copy link
Collaborator

When a Composer based build is packaged, the paths in the autoloader files generated by Composer should be updated to match the structure of the package output.

The goals are:

  • It should be possible to created package output that can live in the docroot without references outside the docroot.
  • It should also be possible to configure the vendor directory to live at the same level as the docroot.

Follow up from #284.

@arithmetric
Copy link
Collaborator Author

I created this branch with comments on a possible approach to this issue:
https://github.com/phase2/grunt-drupal-tasks/compare/feature/package_rewrite_composer

I'd welcome feedback on the best approach for this. @jhedstrom @grayside @mike-potter

@grayside
Copy link
Contributor

grayside commented Sep 3, 2016

I missed the last update here, will check it out soon.

In the meantime, Pantheon may have simplified the problem just recently: https://pantheon.io/docs/nested-docroot/

@grayside
Copy link
Contributor

grayside commented Sep 3, 2016

In review of the proposed approach I think it's on the right track. If the GDT buildpath does not match the configured package docroot it is set up to rewrite the composer.json before re-running the composer install we put in place to remove dev dependencies.

I have potentially breaking changes in mind with #255 and #24 but nothing I see here is out of the way for those changes to similarly support.

@mike-potter
Copy link
Member

Created a PR for this here: #297

Closing this issue since we can discuss it now in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants