You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The same speedup advantage provided in #245 can be had for the grunt package command by replacing it's grunt-copy implementation with grunt-rsync. Currently, larger Drupal sites such as those based on Atrium blow the default Node callstack, and fail to complete after several minutes. I've tested an rsync implementation that works with no problem.
The downside here is that grunt-rsync is
not easily assumed as available on Windows
not configuration compatibility with grunt-copy, or more specifically, with the minimatch library which drives the file globbing for copy.
In order to address these issues but still default to fast, I propose we take the following steps:
In the event that the new util.canRsync function returns false or grunt package is invoked with a new --copy flag, use copy, otherwise we default to rsync.
Document that minimatch's more advanced features should not be used.
Possibly adjust the default package configuration to comply if it does not already, in both the GDT tests and generator-gadget.
The text was updated successfully, but these errors were encountered:
The same speedup advantage provided in #245 can be had for the grunt package command by replacing it's grunt-copy implementation with grunt-rsync. Currently, larger Drupal sites such as those based on Atrium blow the default Node callstack, and fail to complete after several minutes. I've tested an rsync implementation that works with no problem.
The downside here is that grunt-rsync is
In order to address these issues but still default to fast, I propose we take the following steps:
false
orgrunt package
is invoked with a new--copy
flag, use copy, otherwise we default to rsync.The text was updated successfully, but these errors were encountered: