Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated grunt package to use rsync instead of copy #252

Closed
grayside opened this issue Mar 4, 2016 · 1 comment
Closed

Updated grunt package to use rsync instead of copy #252

grayside opened this issue Mar 4, 2016 · 1 comment

Comments

@grayside
Copy link
Contributor

grayside commented Mar 4, 2016

The same speedup advantage provided in #245 can be had for the grunt package command by replacing it's grunt-copy implementation with grunt-rsync. Currently, larger Drupal sites such as those based on Atrium blow the default Node callstack, and fail to complete after several minutes. I've tested an rsync implementation that works with no problem.

The downside here is that grunt-rsync is

  1. not easily assumed as available on Windows
  2. not configuration compatibility with grunt-copy, or more specifically, with the minimatch library which drives the file globbing for copy.

In order to address these issues but still default to fast, I propose we take the following steps:

  1. In the event that the new util.canRsync function returns false or grunt package is invoked with a new --copy flag, use copy, otherwise we default to rsync.
  2. Document that minimatch's more advanced features should not be used.
  3. Possibly adjust the default package configuration to comply if it does not already, in both the GDT tests and generator-gadget.
@grayside
Copy link
Contributor Author

#255 duplicates this. Both by me, same week. Bah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant