Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fancy drupal core version lookup #90

Open
grayside opened this issue May 12, 2017 · 1 comment
Open

Remove fancy drupal core version lookup #90

grayside opened this issue May 12, 2017 · 1 comment

Comments

@grayside
Copy link
Contributor

In master right now is a overly complicated system. Let's uncomplicate it.

  1. The Drupal 8 composer template has drupal/core: true as opposed to a real semver range or version.
  2. Elsewhere, we are detecting that value is present, and performing a lookup of the Drupal.org update system to find the latest stable minor release of D8.
  3. This is then injected into the template.
  4. That value is then used by another not-quite-open generator to make decisions about things like docker images to use.

Let's just change the value to ^8.3 or the like, remove that particular spot of cleverness from this generator doing the lookup, make sure Octane successfully removes drupal/core from it's template, and then test that this generator and the other generator both work.

@mike-potter
Copy link
Member

Agreed, although "^8.0" might make the intention even clearer so people don't assume they need to change it to "^8.4" when that comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants