Adds a project-specific phpunit.xml file. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhedstrom
commented
Aug 8, 2017
| <!-- Example SIMPLETEST_BASE_URL value: http://localhost --> | ||
| <env name="SIMPLETEST_BASE_URL" value="http://project.vm"/> | ||
| <!-- Example SIMPLETEST_DB value: mysql://username:password@localhost/databasename#table_prefix --> | ||
| <env name="SIMPLETEST_DB" value=""/> |
There was a problem hiding this comment.
Environment variables override these, so if we were to set those in one of the rig generators, that would work. This would still be nice to have set, but could be an @todo for the time being. Having this file in the project root would at least make configuration of testing clearer for devs I think.
|
This seems like a decent plan, I'd like to test this out and coordinate with generator-outrigger-drupal before merging. There should also be test coverage to at least confirm generation of the phpunit.xml.dist file on generator runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs work, as I'm forgetting how/when db credentials are available. We need to properly populate this bit of the file: