Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issue: Restructure Files for ADEG and ADVS Parameters #2551

Open
bundfussr opened this issue Nov 4, 2024 · 1 comment
Open

General Issue: Restructure Files for ADEG and ADVS Parameters #2551

bundfussr opened this issue Nov 4, 2024 · 1 comment
Labels

Comments

@bundfussr
Copy link
Collaborator

Background Information

The files derive_adeg_parms.R and derive_advs_parms.R should be restructured such that there is one file per "parameter". E.g., derive_param_qtc.R contains derive_param_qtc() and compute_qtc().
The test files should be restructured accordingly.

Definition of Done

derive_adeg_parms.R and derive_advs_parms.R and their test files are replaced.

@bms63
Copy link
Collaborator

bms63 commented Nov 4, 2024

@pharmaverse/admiral @pharmaverse/admiral_comm great issue to dig into the files of admiral and get familiar with some some of the functions. This is probably 1 hour of work and might produce some "uuummmm...moments" that we will need to discuss in the Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants