-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Enhance documentation for derive_var_joined_exist_flag()
#2523
Comments
@bms63 funny enough i had to implement something internally using this function for a BDS and i had an idea to extend the examples with the following scenario which i didn't find easy to figure out:
Is it OK that I take this function examples update on? Or from the label are we leaving this open for new contributors from R/Pharma? p.s. I don't ever agree with the suggestion of including SAS pseudo code in our R package function examples though. You can explain enough what you're doing in plain english comments, and up to certain users if they prefer to first translate that into SAS language for comparison. Imagine all our users who don't "speak SAS" who would only find this confusing. |
Yes please take on!! Makes sense on not providing the SAS code :) |
thanks both - will make a PR next week 🫡 |
Background
derive_var_joined_exist_flag() can be a challenging function to use - more simple examples will help show its power and ease of use. The example below is a nice showcase. The SAS code can be included as that is our user base (for now!) to bring in more understanding.
Originally posted by @yurovska in pharmaverse/admiralmetabolic#31 (comment)
Definition of Done
* SAS pseudo Code is also provided in exampleThe text was updated successfully, but these errors were encountered: