-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Implement derive_vars_crit_flag()
#2468
Comments
I think this looks useful! Do we want to use Also, we have the hy's law vignette which discusses Crit flags - maybe opportunity to update with this function? https://pharmaverse.github.io/admiral/articles/hys_law.html What do you think @pharmaverse/admiral and @pharmaverse/admiral_comm? Any takers? I think this could be a fun one to implement for those eager to do some function building for admiral!! |
Yes, seems reasonable to me. |
derive_vars_crit()
derive_vars_crit_flag()
Looks reasonable to me as well, thanks for the suggestion @bundfussr. Just for general awareness, in admiralophtha we have On another note, could we couple this effort with a similar function for |
@manciniedoardo , what do you have in mind? Should it derive |
Actually it was just a passing thought, I haven't looked in the IG yet to see if AVALCAT/CHGCAT have as stringent guidelines. My thought was that if yes, maybe we could also develop |
AVALCATy has a restriction that it can only be derived using values of AVAL or AVALC. CHGCATy is under a similar restriction- it can only be derived using values of CHG. AGEGRy should only be derived based on values of age, but which age variable is used is up to the producer, since multiple age variables are possible in ADSL. |
Thanks @nbrucken17 - if that is all maybe this is not a good idea, as you may just as well derive them inside a mutate statement! |
Feature Idea
Implement
derive_vars_crit_flag()
which derives the variablesCRITy
,CRITyFL
, andCRITyFLN
(for a specific value ofy
). The derivation of these variables is very simple. However, there are some requirements which many programmers and specs authors are not aware of. For example, that the derivation must rely on variables from the current records only and the relation of the values ofCRITy
andCRITyFL
(e.g., ifCRITyFL
is set to"Y"
or"N"
,CRITy
must be populated for all records with the same value).The function should cover all use cases of the
CRIT
variables. I.e., if aCRIT
variable can not be derived with the function, the derivation is not ADaM compliant.Relevant Input
No response
Relevant Output
No response
Reproducible Example/Pseudo Code
The text was updated successfully, but these errors were encountered: