Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: keep_source_var to be applicable across appropriate family of functions #2185

Closed
zdz2101 opened this issue Oct 24, 2023 · 3 comments
Closed

Feature Request: keep_source_var to be applicable across appropriate family of functions #2185

zdz2101 opened this issue Oct 24, 2023 · 3 comments
Assignees
@zdz2101
Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming

Comments

@zdz2101
Copy link
Collaborator

zdz2101 commented Oct 24, 2023 •
edited
Loading

Feature Idea

#2010 (comment)

https://pharmaverse.slack.com/archives/C028SJ83KM1/p1692633891115359

In our slack post, we have a proposal to make the argument keep_source_var consistent across all selection functions which add new observations.

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@zdz2101 zdz2101 added enhancement New feature or request programming function re-work issues identified by function re-work gang - usually argument alignment, user friendliness release Q4-2023 labels Oct 24, 2023
@zdz2101 zdz2101 self-assigned this Oct 27, 2023
zdz2101 pushed a commit that referenced this issue Nov 1, 2023
@jerryekohe
feat: #2185 first implementation of keep_source_vars
50e873d
@bundfussr
Copy link
Collaborator

Didn't we implement it in #1697?

@zdz2101
Copy link
Collaborator Author

zdz2101 commented Nov 2, 2023

Didn't we implement it in #1697?

Think we missed some, I have a draft for derive_param_tte() for example

@zdz2101 zdz2101 linked a pull request Nov 2, 2023 that will close this issue
Closes #2185 additional implementation of keep_source_vars #2215
Closed
14 tasks
zdz2101 pushed a commit that referenced this issue Nov 2, 2023
@jerryekohe
feat: #2185 add news blurb
537936f
zdz2101 added a commit that referenced this issue Nov 8, 2023
@zdz2101
chore: #2185 clean up errors
71fb435
@bms63
Copy link
Collaborator

bms63 commented Nov 13, 2023

It was decided to not implement this feature. See here for discussion - #2215 (comment)

@bms63 bms63 closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdz2101 zdz2101

Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2185 additional implementation of keep_source_vars pharmaverse/admiral
3 participants
@bms63 @zdz2101 @bundfussr