Enhancement/display pp adpp

[Gero1999]

Issue

Closes #66

Description

Renaming the tab from "CDISC" to "PP/ADPP"
Showing an in-app-display of the datasets in the tab
Renaming the download button from "Export CDISC" to "Download PP/ADPP" (I ended up with Parameter datasets)

Definition of Done and how to test

• After running NCA is easy to identify where to find PP/ADPP files
• You can download each file
• File formats seem correct

How to test

NCA > Choose the analyte > Submit > Settings > Choose the Dose Number > Run NCA > See Outputs > Parameter datasets

Contributor checklist

• Code passes lintr checks
• Code passes all unit tests
• New logic covered by unit tests
• New logic is documented

Notes to reviewer

Anything that the reviewer should know before tacking the pull request?

[js3110]

Looks good, a couple things I have noticed:

1. In ADPP, the parameter is not specified. The PARAM column contains the analyte, which is also in another column.
2. Spelling error- should be 'Unspecified' not 'Unespecified'

Another suggestion but not required is maybe moving this tab to the NCA section? As outputs will become visualisation section and I think this tab is more relevant in the NCA section. But can be reviewed later.

[Gero1999]

Good catch @js3110 , issues should be fine now, thanks!

And regarding the rearrangement, I agree with you that this makes a lot of sense in NCA results. Once our main issues are addresed we will rearrange all output tabs.

[js3110]

@Gero1999 looks much better nice work !
Approved, but one optional thing that I think would look nicer is instead of having two separate buttons for csv and excel, you just have one download button and the user can choose between .csv and excel as the file type.

[m-kolomanski]

Looks fine in general, I have a suggestion regarding pattern usage and readability.

[m-kolomanski]

issue: Try not mixing base R and dplyr patters, as the code becomes harder to comprehend. I would also clean up older code and do:

  adpp <- pp_info %>%
    # Elude potential collapse cases with PC variables
    select(-any_of(c("AVAL", "AVALC", "AVALU"))) %>%
    rename(AVAL = PPSTRESN, AVALC = PPSTRESC, AVALU = PPSTRESU)  %>%
    left_join(
      res_nca$data$dose$data %>%
        select(-any_of(setdiff(names(pp_info), "USUBJID"))),
      by = "USUBJID"
    ) %>%
    select(any_of(adpp_col))

[Gero1999]

Yes, I completely agree. I sometimes miss these things, I promise to pay more attention to this from now on!